Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong ranges for binary literal + in #31292

Merged
merged 7 commits into from
Jan 5, 2022
Merged

planner: fix wrong ranges for binary literal + in #31292

merged 7 commits into from
Jan 5, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 4, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31261

Problem Summary: planner: planner: fix wrong ranges for binary literal + in

What is changed and how it works?

Like #23699 and what we do for other cmp operators, refine range values when building ranges for in + binary literal.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

planner: fix wrong ranges for binary literal + `in`

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 4, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2022
@qw4990 qw4990 changed the title planner: fix wrong ranges built from binary literal planner: fix wrong ranges for binary literal + in Jan 4, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/68b7a5034ba0ae1054530addf12ee92754219801

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 4, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 31e3268

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jan 5, 2022

/merge

@qw4990 qw4990 merged commit 11be429 into pingcap:master Jan 5, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 5, 2022
@qw4990 @ti-srebot
cherry pick pingcap#31292 to release-5.4
b7ca39f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 5, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31339

ti-chi-bot pushed a commit that referenced this pull request Jan 6, 2022
@ti-srebot
planner: fix wrong ranges for binary literal + in (#31292) (#31339)
4ad7f7e 
close #31261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@rebelice rebelice rebelice approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: planner return TableDual if InStatement contain duplicate values
7 participants
@qw4990 @ti-chi-bot @sre-bot @hawkingrei @ti-srebot @rebelice @Reminiscent